Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1291553005: Add tests for float32/float64 parameters/returns passed in float32/float64 registers. (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add tests for float32/float64 parameters/returns passed in float32/float64 registers. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/8525136bd3b7e360852bccc5b7f4a6b9e44ea22a Cr-Commit-Position: refs/heads/master@{#30143}

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -145 lines) Patch
M test/cctest/compiler/test-run-native-calls.cc View 1 13 chunks +357 lines, -145 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 4 months ago (2015-08-12 16:28:47 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/1291553005/diff/1/test/cctest/compiler/test-run-native-calls.cc File test/cctest/compiler/test-run-native-calls.cc (right): https://codereview.chromium.org/1291553005/diff/1/test/cctest/compiler/test-run-native-calls.cc#newcode33 test/cctest/compiler/test-run-native-calls.cc:33: // Picks a representative set of integers from ...
5 years, 4 months ago (2015-08-12 17:48:41 UTC) #2
titzer
On 2015/08/12 17:48:41, Michael Starzinger wrote: > LGTM. > > https://codereview.chromium.org/1291553005/diff/1/test/cctest/compiler/test-run-native-calls.cc > File test/cctest/compiler/test-run-native-calls.cc (right): ...
5 years, 4 months ago (2015-08-13 05:04:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291553005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291553005/20001
5 years, 4 months ago (2015-08-13 05:05:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-13 05:29:56 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 05:30:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8525136bd3b7e360852bccc5b7f4a6b9e44ea22a
Cr-Commit-Position: refs/heads/master@{#30143}

Powered by Google App Engine
This is Rietveld 408576698