base/logging.cc - Issue 1291553003: Print stack traces in child processes when browser tests failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.cc

Issue 1291553003: Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch 1295823002 which fixes the console coming up on Win8+ and adds regression tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/logging.cc

diff --git a/base/logging.cc b/base/logging.cc

index 559cb083b6ad3227e161ed57dc551a51a699b46a..ea731610dd59fe1006f9a11d89a10589b3ffe08a 100644

--- a/base/logging.cc

+++ b/base/logging.cc

@@ -543,7 +543,7 @@ LogMessage::LogMessage(const char* file, int line, LogSeverity severity,

}

LogMessage::~LogMessage() {

-#if !defined(NDEBUG) && !defined(OS_NACL) && !defined(__UCLIBC__)

+#if !defined(OFFICIAL_BUILD) && !defined(OS_NACL) && !defined(__UCLIBC__)

if (severity_ == LOG_FATAL) {

// Include a stack trace on a fatal.

base::debug::StackTrace trace;

« base/debug/stack_trace_win.cc ('K') | « base/debug/stack_trace_win.cc ('k') | base/process/launch.h » ('j') | content/app/content_main_runner.cc » ('J')