Print stack traces in child processes when browser tests failed.

content/common/sandbox_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/sandbox_win.h"
 
 #include <string>
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
@@ skipping 310 matching lines @@
 
   base::FilePath debug_message(long_path_buf);
   debug_message = debug_message.AppendASCII("debug_message.exe");
   result = policy->AddRule(sandbox::TargetPolicy::SUBSYS_PROCESS,
                            sandbox::TargetPolicy::PROCESS_MIN_EXEC,
                            debug_message.value().c_str());
   if (result != sandbox::SBOX_ALL_OK)
     return false;
 #endif  // NDEBUG
 
-  // Add the policy for read-only PDB file access for AddressSanitizer.
-#if defined(ADDRESS_SANITIZER)
+  // Add the policy for read-only PDB file access for stack traces.
+#if !defined(OFFICIAL_BUILD)
   base::FilePath exe;
   if (!PathService::Get(base::FILE_EXE, &exe))
     return false;
   base::FilePath pdb_path = exe.DirName().Append(L"*.pdb");
   result = policy->AddRule(sandbox::TargetPolicy::SUBSYS_FILES,
                            sandbox::TargetPolicy::FILES_ALLOW_READONLY,
                            pdb_path.value().c_str());
   if (result != sandbox::SBOX_ALL_OK)
     return false;
 #endif
@@ skipping 391 matching lines @@
                              exposed_files.value().c_str());
     if (result != sandbox::SBOX_ALL_OK)
       return base::Process();
   }
 
   if (!AddGenericPolicy(policy)) {
     NOTREACHED();
     return base::Process();
   }
 
-  if (browser_command_line.HasSwitch(switches::kEnableLogging)) {
-    // If stdout/stderr point to a Windows console, these calls will
-    // have no effect.
-    policy->SetStdoutHandle(GetStdHandle(STD_OUTPUT_HANDLE));
-    policy->SetStderrHandle(GetStdHandle(STD_ERROR_HANDLE));
-  }
+#if !defined(OFFICIAL_BUILD)
+  // If stdout/stderr point to a Windows console, these calls will
+  // have no effect.
+  policy->SetStdoutHandle(GetStdHandle(STD_OUTPUT_HANDLE));
+  policy->SetStderrHandle(GetStdHandle(STD_ERROR_HANDLE));
+#endif
 
   if (delegate) {
     bool success = true;
     delegate->PreSpawnTarget(policy, &success);
     if (!success)
       return base::Process();
   }
 
   TRACE_EVENT_BEGIN_ETW("StartProcessWithAccess::LAUNCHPROCESS", 0, 0);
 
@@ skipping 67 matching lines @@
   }
 
   return false;
 }
 
 bool BrokerAddTargetPeer(HANDLE peer_process) {
   return g_broker_services->AddTargetPeer(peer_process) == sandbox::SBOX_ALL_OK;
 }
 
 }  // namespace content