Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: chrome/browser/web_resource/promo_resource_service.h

Issue 1291543004: Inject JSON parsing in WebResource as a callback rather than inheritance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webResources1
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/promo_resource_service.h
diff --git a/chrome/browser/web_resource/promo_resource_service.h b/chrome/browser/web_resource/promo_resource_service.h
index faf1970845c5d890098019ec7da7fff2fb7e3904..2908286634c3c596edb9bcb8d715dadb98bbf390 100644
--- a/chrome/browser/web_resource/promo_resource_service.h
+++ b/chrome/browser/web_resource/promo_resource_service.h
@@ -10,7 +10,7 @@
#include "base/callback_forward.h"
#include "base/callback_list.h"
#include "base/memory/weak_ptr.h"
-#include "chrome/browser/web_resource/chrome_web_resource_service.h"
+#include "components/web_resource/web_resource_service.h"
class NotificationPromo;
class PrefRegistrySimple;
@@ -32,7 +32,7 @@ enum class Channel;
// dynamically change the appearance of the New Tab Page. For example, it has
// been used to fetch "tips" to be displayed on the NTP, or to display
// promotional messages to certain groups of Chrome users.
-class PromoResourceService : public ChromeWebResourceService {
+class PromoResourceService : public web_resource::WebResourceService {
public:
using StateChangedCallbackList = base::CallbackList<void()>;
using StateChangedSubscription = StateChangedCallbackList::Subscription;
@@ -41,7 +41,12 @@ class PromoResourceService : public ChromeWebResourceService {
static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
static void MigrateUserPrefs(PrefService* user_prefs);
- PromoResourceService(PrefService* local_state, version_info::Channel channel);
+ PromoResourceService(PrefService* local_state,
+ version_info::Channel channel,
+ const std::string& application_locale,
+ net::URLRequestContextGetter* request_context,
+ const char* disable_network_switch,
+ const ParseJSONCallback& parse_json_callback);
~PromoResourceService() override;
// Registers a callback called when the state of a web resource has been
« no previous file with comments | « chrome/browser/web_resource/chrome_web_resource_service.cc ('k') | chrome/browser/web_resource/promo_resource_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698