Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3926)

Unified Diff: chrome/browser/web_resource/chrome_web_resource_service.cc

Issue 1291543004: Inject JSON parsing in WebResource as a callback rather than inheritance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webResources1
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/chrome_web_resource_service.cc
diff --git a/chrome/browser/web_resource/chrome_web_resource_service.cc b/chrome/browser/web_resource/chrome_web_resource_service.cc
deleted file mode 100644
index 47a1335316ebe87ca1856f1b675138890687497d..0000000000000000000000000000000000000000
--- a/chrome/browser/web_resource/chrome_web_resource_service.cc
+++ /dev/null
@@ -1,42 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/web_resource/chrome_web_resource_service.h"
-
-#include <string>
-
-#include "base/memory/ref_counted.h"
-#include "chrome/browser/browser_process.h"
-#include "chrome/common/chrome_switches.h"
-#include "components/safe_json/safe_json_parser.h"
-#include "url/gurl.h"
-
-ChromeWebResourceService::ChromeWebResourceService(
- PrefService* prefs,
- const GURL& web_resource_server,
- bool apply_locale_to_url,
- const char* last_update_time_pref_name,
- int start_fetch_delay_ms,
- int cache_update_delay_ms)
- : web_resource::WebResourceService(
- prefs,
- web_resource_server,
- apply_locale_to_url ? g_browser_process->GetApplicationLocale()
- : std::string(),
- last_update_time_pref_name,
- start_fetch_delay_ms,
- cache_update_delay_ms,
- g_browser_process->system_request_context(),
- switches::kDisableBackgroundNetworking) {
-}
-
-ChromeWebResourceService::~ChromeWebResourceService() {
-}
-
-void ChromeWebResourceService::ParseJSON(
- const std::string& data,
- const SuccessCallback& success_callback,
- const ErrorCallback& error_callback) {
- safe_json::SafeJsonParser::Parse(data, success_callback, error_callback);
-}
« no previous file with comments | « chrome/browser/web_resource/chrome_web_resource_service.h ('k') | chrome/browser/web_resource/promo_resource_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698