tools/perf/page_sets/repeatable_synthesize_scroll_gesture_shared_state.py - Issue 1291513004: smoothness.scrolling_tough_ad_cases to use browser driven scrolls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/repeatable_synthesize_scroll_gesture_shared_state.py

Issue 1291513004: smoothness.scrolling_tough_ad_cases to use browser driven scrolls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Responding to feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/repeatable_synthesize_scroll_gesture_shared_state.py

diff --git a/tools/perf/page_sets/fling_gesture_supported_shared_state.py b/tools/perf/page_sets/repeatable_synthesize_scroll_gesture_shared_state.py

similarity index 53%

copy from tools/perf/page_sets/fling_gesture_supported_shared_state.py

copy to tools/perf/page_sets/repeatable_synthesize_scroll_gesture_shared_state.py

index afcdcde542b85aca4529aa526fabc242648bf2f3..2c7f97394f17577c4bbd7cc09dcb52a15de4626f 100644

--- a/tools/perf/page_sets/fling_gesture_supported_shared_state.py

+++ b/tools/perf/page_sets/repeatable_synthesize_scroll_gesture_shared_state.py

@@ -6,11 +6,12 @@ import logging

from telemetry.page import shared_page_state

-class FlingGestureSupportedSharedState(

- shared_page_state.Shared10InchTabletPageState):

+class RepeatableSynthesizeScrollGestureSharedState(

+ shared_page_state.SharedPageState):

def CanRunOnBrowser(self, browser_info, _):

- if not browser_info.HasFlingGestureSupport():

- logging.warning('Browser does not support fling gestures, skipping test')

+ if not browser_info.HasRepeatableSynthesizeScrollGesture():

+ logging.warning('Browser does not support repatable scroll gestures, '

+ 'skipping test')

return False

return True

« no previous file with comments | « no previous file | tools/perf/page_sets/tough_ad_cases.py » ('j') | tools/perf/page_sets/tough_ad_cases.py » ('J')