tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py - Issue 1291513004: smoothness.scrolling_tough_ad_cases to use browser driven scrolls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py

Issue 1291513004: smoothness.scrolling_tough_ad_cases to use browser driven scrolls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Special handling of TMZ page Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/perf/page_sets/tough_ad_cases.py ('K') | « tools/perf/page_sets/tough_ad_cases.py ('k') | tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py » ('j') | tools/telemetry/telemetry/internal/browser/web_contents.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py

diff --git a/tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py b/tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py

index 3aa050a1f6f31bf9186167fe66fbde5f5e373fc5..b1192e704a334b011b3831b5d35de642702eda39 100644

--- a/tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py

+++ b/tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py

@@ -223,6 +223,21 @@ class InspectorBackend(object):

"""

return self._runtime.EnableAllContexts()

+ @_HandleInspectorWebSocketExceptions

+ def SynthesizeScrollGesture(self, params, timeout=60):

+ """Runs an inspector command.

+ Raises:

+ exceptions.WebSocketDisconnected

+ exceptions.TimeoutException

+ exceptions.DevtoolsTargetCrashException

+ """

+ scroll_command = {

+ 'method': 'Input.synthesizeScrollGesture',

+ 'params': params

+ }

+ return self._runtime.RunInspectorCommand(scroll_command, timeout)

# Timeline public methods.

@property