tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py - Issue 1291513004: smoothness.scrolling_tough_ad_cases to use browser driven scrolls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py

Issue 1291513004: smoothness.scrolling_tough_ad_cases to use browser driven scrolls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Final nits Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py ('k') | tools/telemetry/telemetry/internal/browser/browser_info.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py

diff --git a/tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py b/tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py

index c7864474330b65a93c0c68b56880b853e8232b09..b3c250e0e89fa04ae860c7e5f2ef6921a8546ae4 100644

--- a/tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py

+++ b/tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py

@@ -67,3 +67,14 @@ class InspectorRuntime(object):

self._inspector_websocket.SyncRequest({'method': 'Runtime.enable'},

timeout=30)

return self._max_context_id

+ def RunInspectorCommand(self, command, timeout):

+ """Runs an inspector command.

+ Raises:

+ exceptions.WebSocketDisconnected

+ websocket.WebSocketException

+ socket.error

+ """

+ res = self._inspector_websocket.SyncRequest(command, timeout)

+ return res