Fix a few clang errors while trying to build tools target.

Fix a few clang errors while trying to build tools target.

Most of the errors were like:
../../src/gpu/gl/GrGLEffectMatrix.cpp:74:9: error: variable 'varyingType' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
../../src/gpu/gl/debug/GrDebugGL.h:125:21: error: private field 'fMaxTextureUnits' is not used [-Werror,-Wunused-private-field]
../../src/core/SkBitmapSampler.cpp:312:25: error: private field 'fProcTable' is not used [-Werror,-Wunused-private-field]

R=bsalomon@google.com,scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=8403

[tfarina, 2013-03-23 02:00:09]

Hi guys,

I was trying to build tools 'ninja -C out/Debug tools' to work on converting
pinspect.cpp to SkCommandLineFlags and got these errors.

Please, could you review this to me?

Thanks,

[scroggo, 2013-03-24 14:58:01]

https://codereview.chromium.org/12915007/diff/1/include/core/SkUtils.h
File include/core/SkUtils.h (left):

https://codereview.chromium.org/12915007/diff/1/include/core/SkUtils.h#oldcod...
include/core/SkUtils.h:129: const char* fLabel;
I wonder if we should just #if 0 or remove the entire class. It appears that the
class is not used by chromium or skia. Without these variables (which are if 0'd
out already), the code does not do anything.

[tfarina, 2013-03-24 15:39:24]

On 2013/03/24 14:58:01, scroggo wrote:
> https://codereview.chromium.org/12915007/diff/1/include/core/SkUtils.h
> File include/core/SkUtils.h (left):
> 
>
https://codereview.chromium.org/12915007/diff/1/include/core/SkUtils.h#oldcod...
> include/core/SkUtils.h:129: const char* fLabel;
> I wonder if we should just #if 0 or remove the entire class. It appears that
the
> class is not used by chromium or skia. Without these variables (which are if
0'd
> out already), the code does not do anything.

I confirmed that it isn't used by either chromium or skia. So I removed it in
patch set 2.

Please, take another look.

[bsalomon, 2013-03-25 13:17:00]

The GrGLEffectMatrix change lgtm. I think the displacement effect change is
probably correct but adding sugoi@ to confirm. I'm not familiar enough with the
other code to comment, so adding reed@.

[reed1, 2013-03-25 13:46:13]

lgtm

[sugoi, 2013-03-25 13:55:17]

lgtm

[tfarina, 2013-03-26 21:49:13]

Committed patchset #2 manually as r8403 (presubmit successful).