Issue 12915003: call onGetUPEM to subclasses can optimize it, and place default behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12915003: call onGetUPEM to subclasses can optimize it, and place default behavior (Closed)

Created:
7 years, 9 months ago by reed1

Modified:
7 years, 9 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

call onGetUPEM to subclasses can optimize it, and place default behavior (calling getAdvancedTypefaceMetrics) in base impl. This allows us to remove SkFontHost::GetUnitsPerEm entirely Committed: https://code.google.com/p/skia/source/detail?r=8295

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -28 lines)			Patch
M	trunk/include/core/SkFontHost.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trunk/src/core/SkTypeface.cpp	View	1 chunk	+13 lines, -12 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_FreeType.cpp	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_FreeType_common.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

reed1

7 years, 9 months ago (2013-03-21 15:36:33 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r8295 (presubmit successful).

Expand Messages | Collapse Messages