Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1291483002: DevTools: improved layout for Kbd Shortcuts & Settings (Closed)

Created:
5 years, 4 months ago by paulirish
Modified:
5 years, 4 months ago
Reviewers:
lushnikov, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: improved layout for Kbd Shortcuts & Settings Increase information density and address broken layout. BUG=519609 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200951

Patch Set 1 #

Patch Set 2 : no more space before Shortcuts on left menu #

Total comments: 1

Patch Set 3 : restore previous kbd shortcut order #

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : improved styling for Linux. with lushnikov #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M Source/devtools/front_end/ui/helpScreen.css View 1 2 3 4 5 7 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
paulirish
screenshot in bug. PTAL
5 years, 4 months ago (2015-08-11 18:27:28 UTC) #2
paulirish
where u at bro
5 years, 4 months ago (2015-08-12 23:37:13 UTC) #3
lushnikov
On 2015/08/12 23:37:13, paulirish wrote: > where u at bro Hey Paul! Two columns are ...
5 years, 4 months ago (2015-08-13 04:21:37 UTC) #4
lushnikov
nit comment https://codereview.chromium.org/1291483002/diff/20001/Source/devtools/front_end/ui/helpScreen.css File Source/devtools/front_end/ui/helpScreen.css (right): https://codereview.chromium.org/1291483002/diff/20001/Source/devtools/front_end/ui/helpScreen.css#newcode108 Source/devtools/front_end/ui/helpScreen.css:108: stray line
5 years, 4 months ago (2015-08-13 04:21:56 UTC) #5
paulirish
On 2015/08/13 at 04:21:37, lushnikov wrote: > On 2015/08/12 23:37:13, paulirish wrote: > > where ...
5 years, 4 months ago (2015-08-13 20:56:42 UTC) #6
paulirish
okay. patch uploaded with our linux/windows adjustments.
5 years, 4 months ago (2015-08-15 19:16:26 UTC) #7
pfeldman
lgtm
5 years, 4 months ago (2015-08-17 17:55:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291483002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291483002/100001
5 years, 4 months ago (2015-08-17 17:56:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99107)
5 years, 4 months ago (2015-08-17 20:29:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291483002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291483002/100001
5 years, 4 months ago (2015-08-17 21:00:30 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99257)
5 years, 4 months ago (2015-08-17 23:50:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291483002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291483002/120001
5 years, 4 months ago (2015-08-20 23:04:28 UTC) #20
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 02:23:08 UTC) #21
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200951

Powered by Google App Engine
This is Rietveld 408576698