Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1291463002: Patch fix for "Add jpeg_skip_scanlines() API to libjpeg-turbo" (Closed)

Created:
5 years, 4 months ago by msarett1
Modified:
5 years, 4 months ago
Reviewers:
msarett, agable, Noel Gordon
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch fix for "Add jpeg_skip_scanlines() API to libjpeg-turbo" https://codereview.chromium.org/1271803002/ "jpeg_skip_scanlines() API, a subset decoding optimization aimed at Android, was submitted upstream r1582. Pull that change, and sundry fixes, into the Chromium repo. This new API is targetted at Android devices, not Chrome, and should have no affect on JPEG decode behavior or perf of Chrome. Chrome uses suspending data source JPEG decoding, and the new API does not support such sources. Adding support for suspending data sources is a future TODO, should the need arise (refer to skbug.com/4036)." BUG=515694 BUG=468914 R=agable@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+/631e2dd119d49794e3572b6ca3f16ee39d59f372

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M jdhuff.c View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (2 generated)
msarett
I missed a line when manually integrating the patch. A silly error in my test ...
5 years, 4 months ago (2015-08-11 16:21:46 UTC) #2
msarett
Adding agable, looks like Noel is out of town.
5 years, 4 months ago (2015-08-11 19:57:21 UTC) #4
agable
lgtm
5 years, 4 months ago (2015-08-11 20:03:13 UTC) #5
agable
Committed patchset #1 (id:1) manually as 631e2dd119d49794e3572b6ca3f16ee39d59f372 (presubmit successful).
5 years, 4 months ago (2015-08-11 20:03:21 UTC) #6
Noel Gordon
https://codereview.chromium.org/1291463002/diff/1/jdhuff.c File jdhuff.c (right): https://codereview.chromium.org/1291463002/diff/1/jdhuff.c#newcode663 jdhuff.c:663: JBLOCKROW block = MCU_data ? MCU_data[blkn] : NULL; Confusing: ...
5 years, 4 months ago (2015-08-12 00:39:22 UTC) #7
msarett
5 years, 4 months ago (2015-08-12 12:09:47 UTC) #8
Message was sent while issue was closed.
Yes this was included in the patch that was upstreamed to libjpeg-turbo.  I just
made a mistake and missed it on the first patch.

Powered by Google App Engine
This is Rietveld 408576698