Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1291343008: Fix crash in WebViewImpl::contentsPreferredMinimumSize (Closed)

Created:
5 years, 4 months ago by Rick Byers
Modified:
5 years, 4 months ago
Reviewers:
bokan
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix crash in WebViewImpl::contentsPreferredMinimumSize The call to layout() could invalidate some of the null-checks we did previously. Instead layout first, then do all the null checks. BUG=521479 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Rick Byers
bokan@ PTAL Sorry I missed this. There may have been a pre-existing bug here, but ...
5 years, 4 months ago (2015-08-17 21:38:34 UTC) #2
bokan
lgtm
5 years, 4 months ago (2015-08-18 12:37:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291343008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291343008/1
5 years, 4 months ago (2015-08-18 13:45:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99778)
5 years, 4 months ago (2015-08-18 15:49:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291343008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291343008/1
5 years, 4 months ago (2015-08-18 17:48:17 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 18:54:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200743

Powered by Google App Engine
This is Rietveld 408576698