Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1291343006: Fix a few bugs in the google3 sync scripts. (Closed)

Created:
5 years, 4 months ago by dogben
Modified:
5 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix a few bugs in the google3 sync scripts. BUG=skia: Committed: https://skia.googlesource.com/skia/+/18af0a0080cc2b2b3464292d35a0886cdade551f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M tools/git_clone_to_google3.sh View 3 chunks +9 lines, -3 lines 0 comments Download
M tools/sync_google3.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
dogben
5 years, 4 months ago (2015-08-17 20:41:14 UTC) #2
mtklein
lgtm
5 years, 4 months ago (2015-08-17 20:54:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291343006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291343006/1
5 years, 4 months ago (2015-08-17 21:17:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/18af0a0080cc2b2b3464292d35a0886cdade551f
5 years, 4 months ago (2015-08-17 21:23:07 UTC) #6
dogben
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1295213002/ by benjaminwagner@google.com. ...
5 years, 4 months ago (2015-08-17 21:43:32 UTC) #7
mtklein
On 2015/08/17 21:43:32, Ben Wagner wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 4 months ago (2015-08-17 21:55:49 UTC) #8
dogben
5 years, 4 months ago (2015-08-18 13:46:38 UTC) #9
Message was sent while issue was closed.
On 2015/08/17 21:43:32, Ben Wagner wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1295213002/ by
mailto:benjaminwagner@google.com.
> 
> The reason for reverting is: MacMini buildbots were unable to apply the patch.
> fatal: Could not parse object '18af0a0080cc2b2b3464292d35a0886cdade551f'.
>
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6....
>
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6....
>
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6....
>
http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6....
>
http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6....
>
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6....
> .

Reland is here: https://codereview.chromium.org/1284093003/

Powered by Google App Engine
This is Rietveld 408576698