Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1291343005: [parser] PreParserExpression cleanup (Closed)

Created:
5 years, 4 months ago by caitp (gmail)
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] PreParserExpression cleanup Cleanup/refactoring CL: - Previously dead code is no longer dead - More information exposed to preparser about different literal kinds (should be useful for rewriting https://crrev.com/1168643005 in a simpler way) BUG= R= LOG=N

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -13 lines) Patch
M src/preparser.h View 7 chunks +40 lines, -13 lines 4 comments Download

Messages

Total messages: 4 (1 generated)
caitp (gmail)
Hi, can you take a look? Some refactoring/cleanup split apart from rewriting the destructuring assignment ...
5 years, 4 months ago (2015-08-17 18:26:12 UTC) #1
adamk
A little confused by this patch...isn't this code basically still dead? I'd rather see these ...
5 years, 4 months ago (2015-08-17 18:40:17 UTC) #3
caitp (gmail)
5 years, 4 months ago (2015-08-17 18:44:22 UTC) #4
On 2015/08/17 18:40:17, adamk wrote:
> A little confused by this patch...isn't this code basically still dead? I'd
> rather see these changes as part of a patch that makes use of them (which it
> sounds like is forthcoming, so maybe I'll just wait for that).

It does add some dead code (the NumberLiteral stuff is dead even after the new
patch, so it's cool to remove that --- just there for consistency).
The Object/Array literal stuff is not dead after the forthcoming patch, and the
StringLiteral stuff was previously dead, but updated to be used (although it
admittedly isn't used in any useful way).

Anyways, other patch in progress, this one can wait on it

Powered by Google App Engine
This is Rietveld 408576698