Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1291343003: Ensure we pass on the --no-sandbox to the callstack browser tests when it's specified for TSAN. (Closed)

Created:
5 years, 4 months ago by jam
Modified:
5 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure we pass on the --no-sandbox to the callstack browser tests when it's specified for TSAN. Also disable the tests for official builds, since we don't open the security holes required for symbolization there. BUG=521465, 521554, 517488 TBR=scottmg@chromium.org Committed: https://crrev.com/46eb503ebc9b6b7ecbd23f804cb81702ae252b6e Cr-Commit-Position: refs/heads/master@{#343686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M content/test/content_browser_test_test.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 4 months ago (2015-08-17 15:19:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291343003/1
5 years, 4 months ago (2015-08-17 15:20:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 15:46:08 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/46eb503ebc9b6b7ecbd23f804cb81702ae252b6e Cr-Commit-Position: refs/heads/master@{#343686}
5 years, 4 months ago (2015-08-17 15:46:50 UTC) #6
scottmg
5 years, 4 months ago (2015-08-17 16:52:26 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698