Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 129133002: Update animation classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update animation classes to use OVERRIDE / FINAL when needed Update animation classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, abarth BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M Source/core/animation/AnimatableClipPathOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableColor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableDouble.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableFilterOperations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableLength.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableLengthBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableLengthBoxAndBool.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableLengthPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableLengthSize.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableNeutral.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableRepeatable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimatableSVGLength.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimatableSVGPaint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableShapeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableStrokeDasharrayList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimatableTransform.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableUnknown.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimatableVisibility.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/Animation.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/animation/DocumentTimeline.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InertAnimation.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-08 20:47:51 UTC) #1
esprehn
rslgtm
6 years, 11 months ago (2014-01-09 10:17:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/129133002/1
6 years, 11 months ago (2014-01-09 13:14:29 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 16:18:09 UTC) #4
Message was sent while issue was closed. 
Change committed as 164785

Powered by Google App Engine
This is Rietveld 408576698