[Oilpan] Move WorkerScriptController to Oilpan heap on Oilpan build

Move WorkerScriptController to Oilpan heap on Oilpan build


BUG=509911
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200641

[peria, 2015-08-17 07:20:45]

Patchset #1 (id:1) has been deleted

[peria, 2015-08-17 07:20:51]

Patchset #1 (id:20001) has been deleted

[peria, 2015-08-17 07:20:56]

Patchset #1 (id:40001) has been deleted

[peria, 2015-08-17 07:24:20]

Patchset #1 (id:60001) has been deleted

[peria, 2015-08-17 08:04:41]

peria@chromium.org changed reviewers:
+ haraken@chromium.org, keishi@chromium.org, oilpan-reviews@chromium.org

[peria, 2015-08-17 08:04:41]

PTL.

[keishi, 2015-08-17 08:33:28]

LGTM

[peria, 2015-08-17 08:37:26]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2015-08-17 08:37:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291313002/80001

[commit-bot: I haz the power, 2015-08-17 08:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-17 08:52:49]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[peria, 2015-08-17 08:56:09]

On 2015/08/17 08:52:49, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Ah, I did not notice that keishi@ was not an OWNER of binding/core/v8 files.

[haraken, 2015-08-17 09:43:56]

LGTM

https://codereview.chromium.org/1291313002/diff/80001/Source/bindings/core/v8...
File Source/bindings/core/v8/WorkerScriptController.cpp (right):

https://codereview.chromium.org/1291313002/diff/80001/Source/bindings/core/v8...
Source/bindings/core/v8/WorkerScriptController.cpp:124: }

Shall we add ASSERT(!m_rejectedPromises) to verify that dispose() has been
called before we reach here?

https://codereview.chromium.org/1291313002/diff/80001/Source/bindings/core/v8...
Source/bindings/core/v8/WorkerScriptController.cpp:313: #if ENABLE(OILPAN)

I guess you won't need #if ENABLE(OILPAN).

[peria, 2015-08-17 10:02:44]

The CQ bit was checked by peria@chromium.org

[peria, 2015-08-17 10:02:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/1291313002/#ps100001
(title: "Work for comments")

[commit-bot: I haz the power, 2015-08-17 10:02:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291313002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291313002/100001

[peria, 2015-08-17 10:03:25]

https://codereview.chromium.org/1291313002/diff/80001/Source/bindings/core/v8...
File Source/bindings/core/v8/WorkerScriptController.cpp (right):

https://codereview.chromium.org/1291313002/diff/80001/Source/bindings/core/v8...
Source/bindings/core/v8/WorkerScriptController.cpp:124: }
On 2015/08/17 09:43:56, haraken wrote:
> 
> Shall we add ASSERT(!m_rejectedPromises) to verify that dispose() has been
> called before we reach here?

Done.

https://codereview.chromium.org/1291313002/diff/80001/Source/bindings/core/v8...
Source/bindings/core/v8/WorkerScriptController.cpp:313: #if ENABLE(OILPAN)
On 2015/08/17 09:43:56, haraken wrote:
> 
> I guess you won't need #if ENABLE(OILPAN).

Done.

[commit-bot: I haz the power, 2015-08-17 11:05:06]

Committed patchset #2 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200641