Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: build/android/process_resources.py

Issue 12913028: Output better error messages during build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/process_resources.py
diff --git a/build/android/process_resources.py b/build/android/process_resources.py
index c6619c52935fbc940d88b5fb45d128f8e98f1334..c343a0a1d00bf66d84e948788a48a973ad999389 100755
--- a/build/android/process_resources.py
+++ b/build/android/process_resources.py
@@ -9,7 +9,6 @@
import optparse
import os
import shlex
-import subprocess
from pylib import build_utils
@@ -80,12 +79,12 @@ def main():
package_command.append('--non-constant-id')
if options.custom_package:
package_command += ['--custom-package', options.custom_package]
- subprocess.check_call(package_command)
+ build_utils.CheckCallDie(package_command)
# Crunch image resources. This shrinks png files and is necessary for 9-patch
# images to display correctly.
build_utils.MakeDirectory(options.crunch_output_dir)
- subprocess.check_call([aapt,
+ build_utils.CheckCallDie([aapt,
'crunch',
Yaron 2013/03/28 23:53:10 Nit: fix indent
cjhopman 2013/03/29 00:39:50 Done.
'-S', options.crunch_input_dir,
'-C', options.crunch_output_dir])

Powered by Google App Engine
This is Rietveld 408576698