Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 12913023: Removed the OK button from the action choice dialog. (Closed)

Created:
7 years, 9 months ago by mtomasz
Modified:
7 years, 9 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Removed the OK button from the action choice dialog. The OK button has been removed and since now, selected app is launched on click/touch. TEST=Enter a sd/usb with dcim folder. BUG=222941 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190557

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -30 lines) Patch
M chrome/browser/resources/file_manager/action_choice.html View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/file_manager/css/action_choice.css View 1 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/file_manager/js/action_choice.js View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtomasz
@yoshiki: The ui specs has just changed. PTAL, Thanks.
7 years, 9 months ago (2013-03-25 15:06:12 UTC) #1
yoshiki
lgtm
7 years, 9 months ago (2013-03-25 22:48:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12913023/2001
7 years, 9 months ago (2013-03-25 23:55:04 UTC) #3
mtomasz
7 years, 9 months ago (2013-03-26 04:25:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r190557 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698