Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/renderer/spellchecker/spellcheck_unittest.cc

Issue 12913010: Disable SpellCheckTest.SpellCheckText under ThreadSanitizer v2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/glue/webkit_glue.h" 5 #include "webkit/glue/webkit_glue.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/platform_file.h" 10 #include "base/platform_file.h"
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 break; 460 break;
461 } 461 }
462 } 462 }
463 463
464 EXPECT_TRUE(suggested_word_is_present); 464 EXPECT_TRUE(suggested_word_is_present);
465 } 465 }
466 } 466 }
467 467
468 // This test verifies our spellchecker can split a text into words and check 468 // This test verifies our spellchecker can split a text into words and check
469 // the spelling of each word in the text. 469 // the spelling of each word in the text.
470 TEST_F(SpellCheckTest, SpellCheckText) { 470 #if defined(THREAD_SANITIZER)
471 // SpellCheckTest.SpellCheckText fails under ThreadSanitizer v2.
472 // See http://crbug.com/217909.
473 #define MAYBE_SpellCheckText DISABLED_SpellCheckText
474 #else
475 #define MAYBE_SpellCheckText SpellCheckText
476 #endif // THREAD_SANITIZER
477 TEST_F(SpellCheckTest, MAYBE_SpellCheckText) {
471 static const struct { 478 static const struct {
472 const char* language; 479 const char* language;
473 const wchar_t* input; 480 const wchar_t* input;
474 } kTestCases[] = { 481 } kTestCases[] = {
475 { 482 {
476 // Afrikaans 483 // Afrikaans
477 "af-ZA", 484 "af-ZA",
478 L"Google se missie is om die w\x00EAreld se inligting te organiseer en " 485 L"Google se missie is om die w\x00EAreld se inligting te organiseer en "
479 L"dit bruikbaar en toeganklik te maak." 486 L"dit bruikbaar en toeganklik te maak."
480 }, { 487 }, {
(...skipping 865 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 strlen(kTestCases[i].misspelled), 1353 strlen(kTestCases[i].misspelled),
1347 0, 1354 0,
1348 &misspelling_start, 1355 &misspelling_start,
1349 &misspelling_length, 1356 &misspelling_length,
1350 &suggestions)); 1357 &suggestions));
1351 EXPECT_GE(suggestions.size(), static_cast<size_t>(1)); 1358 EXPECT_GE(suggestions.size(), static_cast<size_t>(1));
1352 if (suggestions.size() > 0) 1359 if (suggestions.size() > 0)
1353 EXPECT_EQ(suggestions[0], ASCIIToUTF16(kTestCases[i].suggestion)); 1360 EXPECT_EQ(suggestions[0], ASCIIToUTF16(kTestCases[i].suggestion));
1354 } 1361 }
1355 } 1362 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698