Issue 12913009: Predex java libraries

Issue 12913009: Predex java libraries (Closed)

Created:
7 years, 9 months ago by cjhopman

Modified:
7 years, 9 months ago

Reviewers:
shashi, Yaron, Torne, brettw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@antpy

Visibility:
Public.

More Reviews

Description

Predex java libraries dx supports merging of already dexed jars. This means we can dex jars as part of the library target and then just merge them when we build the apk. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191063

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Rebase again #

Patch Set 4 : Update fake jar targets #

Patch Set 5 : Rebase #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -49 lines)			Patch
M	android_webview/android_webview_tests.gypi	View	1 2 3	1 chunk	+1 line, -13 lines	0 comments	Download
A	build/apk_fake_jar.gypi	View	1 2 3	1 chunk	+25 lines, -0 lines	0 comments	Download
M	build/java.gypi	View	1 2 3 4	3 chunks	+25 lines, -0 lines	0 comments	Download
M	build/java_apk.gypi	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_android.gypi	View	1 2 3	1 chunk	+1 line, -17 lines	0 comments	Download
M	content/content_shell.gypi	View	1 2 3	1 chunk	+1 line, -18 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm https://codereview.chromium.org/12913009/diff/2001/build/java.gypi File build/java.gypi (right): https://codereview.chromium.org/12913009/diff/2001/build/java.gypi#newcode68 build/java.gypi:68: # jar path to the classpath of dependent ...

7 years, 9 months ago (2013-03-23 00:33:05 UTC) #2

shashi

lgtm https://codereview.chromium.org/12913009/diff/2001/build/java.gypi File build/java.gypi (right): https://codereview.chromium.org/12913009/diff/2001/build/java.gypi#newcode56 build/java.gypi:56: 'dex_path': '<(PRODUCT_DIR)/lib.java/<(_target_name).dex.jar', nit: it may be cleaner to ...

7 years, 9 months ago (2013-03-23 01:07:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12913009/29003

7 years, 9 months ago (2013-03-26 20:56:44 UTC) #4

cjhopman

brettw: OWNERS for content/ chrome/ torne: for android_webview/

7 years, 9 months ago (2013-03-26 23:16:40 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12913009/49001

7 years, 9 months ago (2013-03-27 20:29:20 UTC) #8

Message was sent while issue was closed.

Change committed as 191063

Expand Messages | Collapse Messages