Issue 12913002: Android: Filter browsertests with MANUAL_ and PRE_ prefix.

Issue 12913002: Android: Filter browsertests with MANUAL_ and PRE_ prefix. (Closed)

Created:
7 years, 9 months ago by nilesh

Modified:
7 years, 9 months ago

Reviewers:
nyquist, Yaron, Isaac (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: Filter browsertests with MANUAL_ and PRE_ prefix. BUG=138275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188875

Patch Set 3 : Renamed method #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
	M	build/android/pylib/browsertests/dispatch.py	View	1 2	2 chunks	+18 lines, -2 lines	0 comments	Download
	M	build/android/pylib/gtest/filter/content_browsertests_disabled	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

nyquist

lgtm overall. I would wait for isaac's comments regarding python though.

7 years, 9 months ago (2013-03-18 16:21:48 UTC) #2

Yaron

lgtm https://codereview.chromium.org/12913002/diff/4001/build/android/pylib/browsertests/dispatch.py File build/android/pylib/browsertests/dispatch.py (right): https://codereview.chromium.org/12913002/diff/4001/build/android/pylib/browsertests/dispatch.py#newcode76 build/android/pylib/browsertests/dispatch.py:76: def _ValidTest(test): Instead of "Valid", call "Automatable"/Bot?

7 years, 9 months ago (2013-03-18 20:41:31 UTC) #5

nilesh

https://codereview.chromium.org/12913002/diff/4001/build/android/pylib/browsertests/dispatch.py File build/android/pylib/browsertests/dispatch.py (right): https://codereview.chromium.org/12913002/diff/4001/build/android/pylib/browsertests/dispatch.py#newcode76 build/android/pylib/browsertests/dispatch.py:76: def _ValidTest(test): On 2013/03/18 20:41:31, Yaron wrote: > Instead ...

7 years, 9 months ago (2013-03-18 22:02:47 UTC) #6

nilesh

7 years, 9 months ago (2013-03-18 23:20:27 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r188875 (presubmit successful).

Expand Messages | Collapse Messages