Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1291283008: Get rid of unused functions kit(TextAffinity) and core(TextAffinity) in TextAffinity.h (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of unused functions kit(TextAffinity) and core(TextAffinity) in TextAffinity.h This patch gets rid of used functions |kit(TextAffinity)| and |core(TextAffinity)| in "TextAffinity.h" to cleanup code for improving code health. This is follow-up of a review comment in http://crrev.com/1293593004. BUG=n/a TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200877

Patch Set 1 : 2015-08-20T13:20:47 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M Source/core/editing/TextAffinity.h View 1 chunk +1 line, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-20 04:37:49 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-20 04:38:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291283008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291283008/1
5 years, 4 months ago (2015-08-20 04:38:50 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 05:22:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200877

Powered by Google App Engine
This is Rietveld 408576698