Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291253003: Remove unimplemented BlockPainter::paintSelection. (Closed)

Created:
5 years, 4 months ago by pdr.
Modified:
5 years, 4 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove unimplemented BlockPainter::paintSelection. This code is not implemented nor called. Discovered while digging into a selection issue. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/paint/BlockPainter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
pdr.
Trivial deadcode
5 years, 4 months ago (2015-08-19 18:27:29 UTC) #2
Xianzhu
lgtm
5 years, 4 months ago (2015-08-19 18:48:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291253003/1
5 years, 4 months ago (2015-08-19 18:49:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/100648)
5 years, 4 months ago (2015-08-19 21:00:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291253003/1
5 years, 4 months ago (2015-08-19 21:05:47 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 22:03:40 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200851

Powered by Google App Engine
This is Rietveld 408576698