Storage Monitor Linux: Do not try to initialize MediaTransferProtocolManager during unit tests.

Storage Monitor Linux: Do not try to initialize MediaTransferProtocolManager during unit tests.

[Greg Billock, 2013-03-26 16:03:43]

https://codereview.chromium.org/12912013/diff/1/chrome/browser/storage_monito...
File chrome/browser/storage_monitor/storage_monitor_linux.h (right):

https://codereview.chromium.org/12912013/diff/1/chrome/browser/storage_monito...
chrome/browser/storage_monitor/storage_monitor_linux.h:109: virtual bool
IsRunningTest() const;
Instead of this, can we make some virtuals that set up and tear down the
manager, and then no-op them in the test?

[Lei Zhang, 2013-03-26 18:32:00]

On 2013/03/26 16:03:43, Greg Billock wrote:
>
https://codereview.chromium.org/12912013/diff/1/chrome/browser/storage_monito...
> File chrome/browser/storage_monitor/storage_monitor_linux.h (right):
> 
>
https://codereview.chromium.org/12912013/diff/1/chrome/browser/storage_monito...
> chrome/browser/storage_monitor/storage_monitor_linux.h:109: virtual bool
> IsRunningTest() const;
> Instead of this, can we make some virtuals that set up and tear down the
> manager, and then no-op them in the test?

But we don't want to run the MediaTransferProtocolManager. i.e. if there were
MTP devices plugged into the computer, they should not affect the unit tests.

[Greg Billock, 2013-03-27 15:48:43]

On 2013/03/26 18:32:00, Lei Zhang wrote:
> On 2013/03/26 16:03:43, Greg Billock wrote:
> >
>
https://codereview.chromium.org/12912013/diff/1/chrome/browser/storage_monito...
> > File chrome/browser/storage_monitor/storage_monitor_linux.h (right):
> > 
> >
>
https://codereview.chromium.org/12912013/diff/1/chrome/browser/storage_monito...
> > chrome/browser/storage_monitor/storage_monitor_linux.h:109: virtual bool
> > IsRunningTest() const;
> > Instead of this, can we make some virtuals that set up and tear down the
> > manager, and then no-op them in the test?
> 
> But we don't want to run the MediaTransferProtocolManager. i.e. if there were
> MTP devices plugged into the computer, they should not affect the unit tests.

Right. So instead of overriding IsRunningTest(), override StartupMTPManager()
and ShutdownMTPManager(). I think that's preferable to having test-only methods.

[Lei Zhang, 2013-03-28 22:41:40]

On 2013/03/27 15:48:43, Greg Billock wrote:
> Right. So instead of overriding IsRunningTest(), override StartupMTPManager()
> and ShutdownMTPManager(). I think that's preferable to having test-only
methods.

It's not possible as is, since MTPManager's Init/Shutdown are static methods.
There's also a weird problem where the shutdown task isn't getting a chance to
run. I'll get back to you on this...