runtime/bin/dbg_connection_macos.h - Issue 1291163002: Join embeder threads on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/dbg_connection_macos.h

Issue 1291163002: Join embeder threads on Windows. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Only wait for read thread in ReadComplete Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/dbg_connection_macos.h

diff --git a/runtime/bin/dbg_connection_macos.h b/runtime/bin/dbg_connection_macos.h

index 966570042c4d31d42f4ed8ece825a2ef235dbd2c..064238e59d081659b0b477ca8a13d4984c3642af 100644

--- a/runtime/bin/dbg_connection_macos.h

+++ b/runtime/bin/dbg_connection_macos.h

@@ -16,6 +16,7 @@ namespace bin {

class DebuggerConnectionImpl {

public:

static void StartHandler(int port_number);

+ static void StopHandler(intptr_t debug_fd) {}

static intptr_t Send(intptr_t socket, const char* buf, int len);

static intptr_t Receive(intptr_t socket, char* buf, int len);