Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 129113003: Revert 243647 "Cast:Adding cast_transport_config and cleaning up" (Closed)

Created:
6 years, 11 months ago by Noam Samuel
Modified:
6 years, 11 months ago
Reviewers:
mikhal1
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 243647 "Cast:Adding cast_transport_config and cleaning up" > Cast:Adding cast_transport_config and cleaning up > > BUG=327482 > > Review URL: https://codereview.chromium.org/109413004 TBR=mikhal@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -593 lines) Patch
M trunk/src/chrome/renderer/media/cast_rtp_stream.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/renderer/media/cast_session_delegate.cc View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_decoder.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_decoder_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_receiver.h View 3 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_receiver.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/media/cast/audio_receiver/audio_receiver_unittest.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/audio_sender/audio_encoder.cc View 7 chunks +10 lines, -11 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_encoder_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_sender.h View 3 chunks +8 lines, -9 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_sender.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M trunk/src/media/cast/audio_sender/audio_sender_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/cast_config.h View 7 chunks +39 lines, -5 lines 0 comments Download
M trunk/src/media/cast/cast_config.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M trunk/src/media/cast/cast_defines.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/cast_environment.h View 3 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/media/cast/cast_environment.cc View 4 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/media/cast/cast_receiver.h View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/media/cast/cast_receiver_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/cast_receiver_impl.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/media/cast/cast_sender.h View 2 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/media/cast/cast_sender_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/cast_sender_impl.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M trunk/src/media/cast/framer/frame_buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/framer/frame_buffer.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/media/cast/framer/frame_buffer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/media/cast/framer/framer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/framer/framer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/framer/framer_unittest.cc View 13 chunks +13 lines, -13 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_receiver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_sender.cc View 20 chunks +37 lines, -37 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_sender_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_utility.h View 1 chunk +14 lines, -0 lines 0 comments Download
M trunk/src/media/cast/rtcp/rtcp_utility.cc View 5 chunks +12 lines, -14 lines 0 comments Download
M trunk/src/media/cast/rtcp/test_rtcp_packet_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/rtcp/test_rtcp_packet_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/rtp_receiver/rtp_parser/rtp_parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/test/encode_decode_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/media/cast/test/end2end_unittest.cc View 20 chunks +25 lines, -22 lines 0 comments Download
M trunk/src/media/cast/test/receiver.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/media/cast/test/sender.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/media/cast/transport/cast_transport.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D trunk/src/media/cast/transport/cast_transport_config.h View 1 chunk +0 lines, -101 lines 0 comments Download
D trunk/src/media/cast/transport/cast_transport_config.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M trunk/src/media/cast/transport/cast_transport_defines.h View 1 chunk +0 lines, -32 lines 0 comments Download
M trunk/src/media/cast/transport/cast_transport_sender.h View 3 chunks +27 lines, -34 lines 0 comments Download
M trunk/src/media/cast/transport/pacing/paced_sender.h View 3 chunks +5 lines, -8 lines 0 comments Download
M trunk/src/media/cast/transport/pacing/paced_sender.cc View 4 chunks +24 lines, -9 lines 0 comments Download
M trunk/src/media/cast/transport/pacing/paced_sender_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M trunk/src/media/cast/transport/rtcp/rtcp_builder.cc View 9 chunks +13 lines, -19 lines 0 comments Download
M trunk/src/media/cast/transport/rtcp/rtcp_builder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/transport/rtp_sender/packet_storage/packet_storage.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/media/cast/transport/rtp_sender/packet_storage/packet_storage.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/media/cast/transport/rtp_sender/rtp_sender.h View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/media/cast/transport/rtp_sender/rtp_sender.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M trunk/src/media/cast/transport/transport/transport.h View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/media/cast/video_receiver/codecs/vp8/vp8_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_receiver/video_decoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/cast/video_receiver/video_decoder.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/media/cast/video_receiver/video_decoder_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/media/cast/video_receiver/video_receiver.h View 3 chunks +8 lines, -9 lines 0 comments Download
M trunk/src/media/cast/video_receiver/video_receiver.cc View 7 chunks +7 lines, -10 lines 0 comments Download
M trunk/src/media/cast/video_receiver/video_receiver_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/media/cast/video_sender/codecs/vp8/vp8_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_sender/codecs/vp8/vp8_encoder.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/media/cast/video_sender/external_video_encoder.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/media/cast/video_sender/external_video_encoder_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_sender/video_encoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cast/video_sender/video_encoder_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_encoder_impl_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_sender.h View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_sender.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M trunk/src/media/cast/video_sender/video_sender_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Noam Samuel
6 years, 11 months ago (2014-01-08 21:22:52 UTC) #1
Noam Samuel
Committed patchset #1 manually as r243648.
6 years, 11 months ago (2014-01-08 21:23:28 UTC) #2
Lei Zhang
6 years, 11 months ago (2014-01-08 21:28:03 UTC) #3
Message was sent while issue was closed. 
Looks like you are another victim of debug vs release builds. Which is why this
CL passed the try bots but failed on the main waterfall. Remember to IWYU.

Powered by Google App Engine
This is Rietveld 408576698