[Custom Tabs]Add API for updating action button in service

chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.customtabs;
 
 import android.app.ActivityManager;
 import android.app.Application;
 import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
 import android.content.ServiceConnection;
 import android.content.pm.PackageManager;
 import android.content.res.Resources;
+import android.graphics.Bitmap;
 import android.graphics.Point;
 import android.net.ConnectivityManager;
 import android.net.Uri;
 import android.os.AsyncTask;
 import android.os.Binder;
 import android.os.Build;
 import android.os.Bundle;
 import android.os.IBinder;
 import android.os.Process;
 import android.os.RemoteException;
 import android.os.SystemClock;
+import android.support.customtabs.CustomTabsCallback;

[Yusuf, 2015/08/21 00:07:37]

why is this one needed?

[Ian Wen, 2015/08/21 17:01:24]

Removed. 

+import android.support.customtabs.CustomTabsIntent;
 import android.support.customtabs.ICustomTabsCallback;
 import android.support.customtabs.ICustomTabsService;
 import android.text.TextUtils;
 import android.util.SparseArray;
 import android.view.WindowManager;
 
 import org.chromium.base.FieldTrialList;
 import org.chromium.base.Log;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.SuppressFBWarnings;
 import org.chromium.base.library_loader.ProcessInitException;
 import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeApplication;
 import org.chromium.chrome.browser.IntentHandler;
 import org.chromium.chrome.browser.WarmupManager;
 import org.chromium.chrome.browser.device.DeviceClassManager;
 import org.chromium.chrome.browser.init.ChromeBrowserInitializer;
 import org.chromium.chrome.browser.prerender.ExternalPrerenderHandler;
 import org.chromium.chrome.browser.profiles.Profile;
+import org.chromium.chrome.browser.util.IntentUtils;
 import org.chromium.content.browser.ChildProcessLauncher;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.content_public.common.Referrer;
 
 import java.io.BufferedReader;
 import java.io.FileReader;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
@@ skipping 256 matching lines @@
             }
         });
         return true;
     }
 
     @Override
     public Bundle extraCommand(String commandName, Bundle args) {
         return null;
     }
 
+    @Override
+    public boolean updateToolbarUI(final ICustomTabsCallback callback, Bundle bundle) {
+        final Bundle actionButtonBundle = IntentUtils.safeGetBundle(bundle,
+                CustomTabsIntent.EXTRA_ACTION_BUTTON_BUNDLE);
+        if (actionButtonBundle == null) return false;
+
+        final Bitmap bitmap = ActionButtonParams.tryParseBitmapFromBundle(mApplication,

[Benoit L, 2015/08/21 11:31:15]

Can't you do:

final ActionButtonParams actionButtonParams =
ActionButtonParams.fromBundle(mApplication, actionButtonBundle);
if (actionButtonParams == null) return false;


and in the Callable:

CustomTabActivity.updateActionButton(callback.asBinder(), actionButtonParams);

[Ian Wen, 2015/08/21 17:01:24]

The reason that I cannot construct an actionButtonParams is that PendingIntent
should not be updated and we don't parse PendingIntent from the bundle. Since we
want to reuse the previous PendingIntent, I have to wait till we get to the
activity and then construct an ActionButtonParams object.

+                actionButtonBundle);
+        final String description = ActionButtonParams
+                .tryParseDescriptionFromBundle(actionButtonBundle);
+        if (bitmap == null || description == null) return false;
+
+        final boolean[] didSucceed = {true};

[Yusuf, 2015/08/21 00:07:37]

use a Callable<Boolean> instead of this.

[Benoit L, 2015/08/21 11:31:15]

Better suggestion than mine, indeed.
Sorry about that. :-)

[Ian Wen, 2015/08/21 17:01:24]

Done.

+
+        ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+            @Override
+            public void run() {
+                didSucceed[0] = CustomTabActivity.updateActionButton(callback.asBinder(), bitmap,
+                        description);
+            }
+        });
+        return didSucceed[0];
+    }
+
     /**
      * Registers a launch of a |url| for a given |session|.
      *
      * This is used for accounting.
      */
     void registerLaunch(IBinder session, String url) {
         int outcome;
         long elapsedTimeMs = -1;
         synchronized (mLock) {
             SessionParams sessionParams = mSessionParams.get(session);
@@ skipping 322 matching lines @@
         return screenSize;
     }
 
     @VisibleForTesting
     void resetThrottling(int uid) {
         synchronized (mLock) {
             mUidToPredictionsStats.put(uid, new PredictionStats());
         }
     }
 }