Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1824)

Unified Diff: base/metrics/field_trial.h

Issue 1291073005: Update full-form autofill config to always query the field trial state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment to field_trial.h Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/ios/browser/autofill_field_trial_ios.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/field_trial.h
diff --git a/base/metrics/field_trial.h b/base/metrics/field_trial.h
index 26257ab4a890b70c257a23e5dfb854c0bf2c78d7..9ccf3b60db6449def69fcafa0d0a37fb55869219 100644
--- a/base/metrics/field_trial.h
+++ b/base/metrics/field_trial.h
@@ -405,7 +405,9 @@ class BASE_EXPORT FieldTrialList {
static int FindValue(const std::string& name);
// Returns the group name chosen for the named trial, or the
Alexei Svitkine (slow) 2015/08/14 16:15:36 Nit: Seems like some of the following line can sti
Justin Donnelly 2015/08/14 17:16:53 Done.
- // empty string if the trial does not exist.
+ // empty string if the trial does not exist. The first call of this function
+ // on a given field trial will mark it as active, so that its state will be
+ // reported with usage metrics, crashes, etc.
static std::string FindFullName(const std::string& name);
// Returns true if the named trial has been registered.
« no previous file with comments | « no previous file | components/autofill/ios/browser/autofill_field_trial_ios.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698