LayoutTests/media/track/track-dispose.html - Issue 1291063002: Test for issue 516298

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/track-dispose.html

Issue 1291063002: Test for issue 516298 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/media/resources/track-dispose-inner.html ('K') | « LayoutTests/media/resources/track-dispose-inner.html ('k') | LayoutTests/media/track/track-dispose-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner) {

	4 testRunner.dumpAsText();

	5 testRunner.waitUntilDone();

	6 }

	7 window.onmessage = function() {

	8 setTimeout(function() {

	9 var iframe = document.querySelector('iframe');

	10 iframe.src = iframe.src;

	11 gc();

	12 setTimeout(function() {

	13 if (window.testRunner)

	14 testRunner.notifyDone();

	15 }, 150);
	philipj_slow 2015/08/13 12:49:15 What is it that happens on a timeout, is it some c What is it that happens on a timeout, is it some cleanup of the iframe, or a GC? You can trigger async GC, but I'm guessing that's not the magic ingredient? fs 2015/08/13 12:59:40 Yeah, so this is the main gratuitous ugliness - it Show quoted text On 2015/08/13 12:49:15, philipj wrote: > What is it that happens on a timeout, is it some cleanup of the iframe, or a GC? > You can trigger async GC, but I'm guessing that's not the magic ingredient? Yeah, so this is the main gratuitous ugliness - it's "re-run the iframe for 150ms". philipj_slow 2015/08/13 13:05:45 Oh, I see, it'll just reload it over and over agai Show quoted text On 2015/08/13 12:59:40, fs wrote: > On 2015/08/13 12:49:15, philipj wrote: > > What is it that happens on a timeout, is it some cleanup of the iframe, or a > GC? > > You can trigger async GC, but I'm guessing that's not the magic ingredient? > > Yeah, so this is the main gratuitous ugliness - it's "re-run the iframe for > 150ms". Oh, I see, it'll just reload it over and over again during 150 ms? Seems fine as long as this in itself does not lead to flakiness, which happened in a somewhat similar setup in the media-element-enqueue-event-crash.html test using localStorage to run 5 times.
	16 }, 0);

	17 }

	18 </script>

	19 <p>PASS if no crash.</p>

	20 <iframe src="../resources/track-dispose-inner.html"></iframe>

OLD	NEW