Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 129103003: [Mac] Check for guest mode correctly before opening the user manager. (Closed)

Created:
6 years, 11 months ago by noms (inactive)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Alexei Svitkine (slow)
Visibility:
Public.

Description

[Mac] Check for guest mode correctly before opening the user manager. BUG=NONE TBR=asvitkine@chromium.org TEST=With the --new-profile-management flag, start Chrome. Select "Browse as guest" from the avatar menu. From the guest browser, select "View all people" from the avatar menu. This shouldn't crash and should show the User Manager. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
noms (inactive)
6 years, 11 months ago (2014-01-08 20:47:44 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 11 months ago (2014-01-08 22:04:42 UTC) #2
noms (inactive)
Thanks! TBR'ing Alexei for an owner stamp, as this is a trivial change.
6 years, 11 months ago (2014-01-08 22:06:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/129103003/1
6 years, 11 months ago (2014-01-08 22:13:15 UTC) #4
Alexei Svitkine (slow)
lgtm
6 years, 11 months ago (2014-01-08 22:13:45 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 00:32:43 UTC) #6
Message was sent while issue was closed.
Change committed as 243710

Powered by Google App Engine
This is Rietveld 408576698