Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1291023005: [PushMessaging] Use appopriate type parameters for WebCallbacks (2/3). (Closed)

Created:
5 years, 4 months ago by yhirano
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, johnme+watch_chromium.org, jam, mvanouwerkerk+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PushMessaging] Use appopriate type parameters for WebCallbacks (2/3). This series of CLs fixes WebCallback parameter types used in PushMessaging. - WebPushSubscription* (ownership transferred) => PassOwnPtr<WebPushSubscription> - WebPushPermissionStatus* (ownership not transferred) => WebPushPermissionStatus - WebPushError* (ownership transferred) => const WebPushError& 1/3: https://codereview.chromium.org/1304723002/ 2/3: https://codereview.chromium.org/1291023005/ 3/3: https://codereview.chromium.org/1302833004/ BUG=493531 Committed: https://crrev.com/ff15b742ada731603ef9070b8fa3f18ed1b45111 Cr-Commit-Position: refs/heads/master@{#344673}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M content/child/push_messaging/push_provider.cc View 1 5 chunks +7 lines, -12 lines 0 comments Download
M content/renderer/push_messaging/push_messaging_dispatcher.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yhirano
5 years, 4 months ago (2015-08-20 06:19:34 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 4 months ago (2015-08-20 13:32:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291023005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291023005/20001
5 years, 4 months ago (2015-08-21 01:08:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-21 03:17:15 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 03:17:56 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff15b742ada731603ef9070b8fa3f18ed1b45111
Cr-Commit-Position: refs/heads/master@{#344673}

Powered by Google App Engine
This is Rietveld 408576698