Issue 12910004: base: Move many JSONValueSerializer unit tests from chrome/common to base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12910004: base: Move many JSONValueSerializer unit tests from chrome/common to base. (Closed)

Created:
7 years, 9 months ago by tfarina

Modified:
7 years, 9 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base: Move many JSONValueSerializer unit tests from chrome/common to base. This seems more appropriate to test these things near where we implement the API, rather than at some random location at chrome common library. The rest wasn't moved yet because they depend on chrome/common/chrome_paths.h and test data that are under chrome. They will be moved next. TEST=base_unittests --gtest_filter=*JSON* R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189315

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+225 lines, -228 lines)			Patch
M	base/json/json_reader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/json/json_value_converter_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/json/json_value_serializer_unittest.cc	View	3 chunks	+219 lines, -1 line	0 comments	Download
M	base/json/json_writer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/json/string_escape.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/json_value_serializer_unittest.cc	View	1 chunk	+2 lines, -223 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

7 years, 9 months ago (2013-03-20 17:00:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r189315 (presubmit successful).

Expand Messages | Collapse Messages