Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1290963005: Add per-file OWNERS for x87-specific cctests. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add per-file OWNERS for x87-specific cctests. BUG= Committed: https://crrev.com/5d0e3b8b94316d0971f50552b77c38b9d60fa22f Cr-Commit-Position: refs/heads/master@{#30182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/cctest/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 4 months ago (2015-08-14 02:39:23 UTC) #2
Jakob Kummerow
lgtm
5 years, 4 months ago (2015-08-14 09:54:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290963005/1
5 years, 4 months ago (2015-08-14 15:37:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 16:02:28 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 16:02:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d0e3b8b94316d0971f50552b77c38b9d60fa22f
Cr-Commit-Position: refs/heads/master@{#30182}

Powered by Google App Engine
This is Rietveld 408576698