Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1290943004: Build all GMs on Android. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
egdaniel, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Build all GMs on Android. Many of these were excluded from the build for bots that no longer exist. Will fix up anything that starts failing using dm_flags.py. BUG=skia:2326, skia:2313, skia:1978 Committed: https://skia.googlesource.com/skia/+/820bffb8937f2a29acb67ab5a4add21febdf1bce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M gyp/gmslides.gypi View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein_C
5 years, 4 months ago (2015-08-14 14:47:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290943004/1
5 years, 4 months ago (2015-08-14 14:48:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-14 14:57:08 UTC) #6
egdaniel
lgtm, but I highly suspect verylargebitmap is going to cause some issues across android
5 years, 4 months ago (2015-08-14 15:02:29 UTC) #7
mtklein
On 2015/08/14 15:02:29, egdaniel wrote: > lgtm, but I highly suspect verylargebitmap is going to ...
5 years, 4 months ago (2015-08-14 15:33:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290943004/1
5 years, 4 months ago (2015-08-14 15:33:15 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 15:33:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/820bffb8937f2a29acb67ab5a4add21febdf1bce

Powered by Google App Engine
This is Rietveld 408576698