Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1290923003: Remove return value statement from the function that have void return type. (Closed)

Created:
5 years, 4 months ago by Deepak
Modified:
5 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, markusheintz_, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing return value statement from the function that have void return type. As the function return type is void so return value not required. and GetSettingsForOneType() also does not return any value. Another change is conversion from char* to char array. BUG=520800 Committed: https://crrev.com/befe2d5015a6d6e97a7380148ee98f0ca40b9951 Cr-Commit-Position: refs/heads/master@{#343357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M components/content_settings/core/browser/cookie_settings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/content_settings/core/browser/website_settings_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Deepak
PTAL
5 years, 4 months ago (2015-08-14 06:19:18 UTC) #2
Bernhard Bauer
LGTM, thanks!
5 years, 4 months ago (2015-08-14 07:56:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290923003/1
5 years, 4 months ago (2015-08-14 08:37:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 09:44:24 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 09:44:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/befe2d5015a6d6e97a7380148ee98f0ca40b9951
Cr-Commit-Position: refs/heads/master@{#343357}

Powered by Google App Engine
This is Rietveld 408576698