Issue 1290913008: Revert of Depend on ETC1 via DEPS instead of a direct third_party checkin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1290913008: Revert of Depend on ETC1 via DEPS instead of a direct third_party checkin. (Closed)

Created:
5 years, 4 months ago by mtklein

Modified:
5 years, 4 months ago

Reviewers:
djsollen, robertphillips, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Depend on ETC1 via DEPS instead of a direct third_party checkin. (patchset #1 id:1 of https://codereview.chromium.org/1296253003/ ) Reason for revert: This will make the google3 roll awkward. Reverting. Original issue's description: > Depend on ETC1 via DEPS instead of a direct third_party checkin. > > Yes, this does mean we'll check out ~40M of code for 2 files... > > I think these trybots are moot... they gclient sync before patching. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ca01d179347b5e848ded97c8228b79ffc6b5e7bf TBR=robertphillips@google.com,djsollen@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/dcbaa8ab6d8179238605955ee2b41f5a9df07348

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+964 lines, -5 lines)			Patch
M	DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/etc1.gyp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
A	third_party/etc1/LICENSE	View	1 chunk	+161 lines, -0 lines	0 comments	Download
A	third_party/etc1/README.google	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	third_party/etc1/etc1.h	View	1 chunk	+114 lines, -0 lines	0 comments	Download
A	third_party/etc1/etc1.cpp	View	1 chunk	+678 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mtklein

Created Revert of Depend on ETC1 via DEPS instead of a direct third_party checkin.

5 years, 4 months ago (2015-08-17 18:14:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290913008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290913008/1

5 years, 4 months ago (2015-08-17 18:14:55 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-17 18:15:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dcbaa8ab6d8179238605955ee2b41f5a9df07348

Expand Messages | Collapse Messages