Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290893005: Remove DocumentLifecycle::Scope's setFinalState, nothing uses it. (Closed)

Created:
5 years, 4 months ago by esprehn
Modified:
5 years, 4 months ago
Reviewers:
pdr., ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove DocumentLifecycle::Scope's setFinalState, nothing uses it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/dom/DocumentLifecycle.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
esprehn
5 years, 4 months ago (2015-08-18 23:08:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290893005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290893005/1
5 years, 4 months ago (2015-08-18 23:08:53 UTC) #4
ojan
lgtm
5 years, 4 months ago (2015-08-18 23:09:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290893005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290893005/1
5 years, 4 months ago (2015-08-18 23:40:12 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 00:43:48 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200769

Powered by Google App Engine
This is Rietveld 408576698