Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1290883004: [Interpreter] Move interpreter initialization until after snapshot deserialization. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 4 months ago
CC:
v8-dev, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Move interpreter initialization until after snapshot deserialization. The interpreter needs to be initialized after the snapshot has been deserialized. BUG=v8:4280 LOG=N Committed: https://crrev.com/2284deeb4624e0b9e985c69da925aab52309a876 Cr-Commit-Position: refs/heads/master@{#30190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/isolate.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rmcilroy
Hannes: could you please take a look, thanks.
5 years, 4 months ago (2015-08-14 15:08:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290883004/1
5 years, 4 months ago (2015-08-14 15:09:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-14 15:35:28 UTC) #6
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-17 09:39:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290883004/1
5 years, 4 months ago (2015-08-17 11:00:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 11:24:38 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 11:24:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2284deeb4624e0b9e985c69da925aab52309a876
Cr-Commit-Position: refs/heads/master@{#30190}

Powered by Google App Engine
This is Rietveld 408576698