Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: net/cookies/cookie_monster.h

Issue 1290873003: Remove unowned Cookie.* histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Un-obsolete the ones we're keeping Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cookies/cookie_monster.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster.h
diff --git a/net/cookies/cookie_monster.h b/net/cookies/cookie_monster.h
index 304fcbf12db17a07c56e7b4316161626cb89a3f4..025dbc03fea541395ce3bb6f04e53cd4db63161f 100644
--- a/net/cookies/cookie_monster.h
+++ b/net/cookies/cookie_monster.h
@@ -529,10 +529,9 @@ class NET_EXPORT CookieMonster : public CookieStore {
// Checks for any duplicate cookies for CookieMap key |key| which lie between
// |begin| and |end|. If any are found, all but the most recent are deleted.
- // Returns the number of duplicate cookies that were deleted.
- int TrimDuplicateCookiesForKey(const std::string& key,
- CookieMap::iterator begin,
- CookieMap::iterator end);
+ void TrimDuplicateCookiesForKey(const std::string& key,
+ CookieMap::iterator begin,
+ CookieMap::iterator end);
void SetDefaultCookieableSchemes();
@@ -663,16 +662,10 @@ class NET_EXPORT CookieMonster : public CookieStore {
// Histogram variables; see CookieMonster::InitializeHistograms() in
// cookie_monster.cc for details.
base::HistogramBase* histogram_expiration_duration_minutes_;
- base::HistogramBase* histogram_between_access_interval_minutes_;
base::HistogramBase* histogram_evicted_last_access_minutes_;
base::HistogramBase* histogram_count_;
- base::HistogramBase* histogram_domain_count_;
- base::HistogramBase* histogram_etldp1_count_;
- base::HistogramBase* histogram_domain_per_etldp1_count_;
- base::HistogramBase* histogram_number_duplicate_db_cookies_;
base::HistogramBase* histogram_cookie_deletion_cause_;
base::HistogramBase* histogram_cookie_type_;
- base::HistogramBase* histogram_time_mac_;
base::HistogramBase* histogram_time_blocked_on_load_;
CookieMap cookies_;
« no previous file with comments | « no previous file | net/cookies/cookie_monster.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698