Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290873003: Remove unowned Cookie.* histograms. (Closed)

Created:
5 years, 4 months ago by Elly Fong-Jones
Modified:
5 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unowned Cookie.* histograms. Remove unowned histograms and mark them obsolete in histograms.xml. This also removes a bunch of stats-gathering code from CookieMonster. BUG=521135 Committed: https://crrev.com/cabf574274dbc72c6cad987e5d9864931bdf7caa Cr-Commit-Position: refs/heads/master@{#344827}

Patch Set 1 #

Patch Set 2 : Reinstate two histograms #

Total comments: 2

Patch Set 3 : Un-obsolete the ones we're keeping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -78 lines) Patch
M net/cookies/cookie_monster.h View 1 2 chunks +3 lines, -10 lines 0 comments Download
M net/cookies/cookie_monster.cc View 1 8 chunks +5 lines, -66 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 6 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Elly Fong-Jones
rdsmith: ptal at deleted code in CookieMonster? isherman: ptal at histograms.xml changes? :)
5 years, 4 months ago (2015-08-17 18:24:57 UTC) #2
Ilya Sherman
histograms.xml lgtm -- thanks for the cleanup!
5 years, 4 months ago (2015-08-17 18:48:22 UTC) #3
Elly Fong-Jones
rdsmith: updated per discussions on the bug, ptal?
5 years, 4 months ago (2015-08-18 16:18:33 UTC) #4
Randy Smith (Not in Mondays)
https://codereview.chromium.org/1290873003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1290873003/diff/20001/tools/metrics/histograms/histograms.xml#oldcode4443 tools/metrics/histograms/histograms.xml:4443: <histogram name="Cookie.DeletionCause" enum="CookieDeletionCause"> I thought we were keeping this?
5 years, 4 months ago (2015-08-20 20:52:24 UTC) #5
Elly Fong-Jones
https://codereview.chromium.org/1290873003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1290873003/diff/20001/tools/metrics/histograms/histograms.xml#oldcode4443 tools/metrics/histograms/histograms.xml:4443: <histogram name="Cookie.DeletionCause" enum="CookieDeletionCause"> On 2015/08/20 20:52:24, rdsmith wrote: > ...
5 years, 4 months ago (2015-08-21 15:05:27 UTC) #6
Randy Smith (Not in Mondays)
LGTM.
5 years, 4 months ago (2015-08-21 15:13:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290873003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290873003/40001
5 years, 4 months ago (2015-08-21 15:19:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/96811)
5 years, 4 months ago (2015-08-21 16:23:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290873003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290873003/40001
5 years, 4 months ago (2015-08-21 17:19:08 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-21 18:45:00 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 18:45:35 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cabf574274dbc72c6cad987e5d9864931bdf7caa
Cr-Commit-Position: refs/heads/master@{#344827}

Powered by Google App Engine
This is Rietveld 408576698