Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 1290833003: Add a simple script to simulate BUILD file glob() expansion. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
hal.canary, dogben, mtklein
CC:
reviews_skia.org, hal.canary, melanielc_google.com
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a simple script to simulate BUILD file glob() expansion. This lets us test changes to BUILD.public. This is not yet automated in any way. My hope is to trigger it quietly via the presubmit for any CL that adds or removes a file, or changes BUILD.public. BUG=skia: Committed: https://skia.googlesource.com/skia/+/df5b7603d2d2bb3ec75cfbf235a672ee80cf8d3a

Patch Set 1 #

Patch Set 2 : note #

Patch Set 3 : reword #

Patch Set 4 : spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+887 lines, -0 lines) Patch
A tools/BUILD.public.expected View 1 2 1 chunk +845 lines, -0 lines 0 comments Download
A tools/BUILD_simulator.py View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mtklein
5 years, 4 months ago (2015-08-17 21:51:48 UTC) #2
mtklein
+CC Melanie
5 years, 4 months ago (2015-08-17 21:54:02 UTC) #3
dogben
lgtm
5 years, 4 months ago (2015-08-17 21:56:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290833003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290833003/60001
5 years, 4 months ago (2015-08-17 21:57:03 UTC) #6
hal.canary
style nit: imports at the top.
5 years, 4 months ago (2015-08-17 21:57:15 UTC) #8
mtklein
On 2015/08/17 21:57:15, Hal Canary wrote: > style nit: imports at the top. This is ...
5 years, 4 months ago (2015-08-17 21:59:45 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 22:03:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/df5b7603d2d2bb3ec75cfbf235a672ee80cf8d3a

Powered by Google App Engine
This is Rietveld 408576698