Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3229)

Unified Diff: webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

Issue 12908004: Lazy initialize WGC3DInProcessCommandBufferImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
diff --git a/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h b/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
index 260779ea0a9f5bf517dec106d5583283367435b6..a8bbc10d666304c2e328f970ed97d91ce66b4fac 100644
--- a/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
+++ b/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
@@ -46,12 +46,10 @@ class WEBKIT_GPU_EXPORT WebGraphicsContext3DInProcessCommandBufferImpl
: public NON_EXPORTED_BASE(WebKit::WebGraphicsContext3D) {
public:
- WebGraphicsContext3DInProcessCommandBufferImpl();
+ WebGraphicsContext3DInProcessCommandBufferImpl(
+ const WebKit::WebGraphicsContext3D::Attributes& attributes);
virtual ~WebGraphicsContext3DInProcessCommandBufferImpl();
- bool Initialize(WebKit::WebGraphicsContext3D::Attributes attributes,
- WebKit::WebGraphicsContext3D* view_context);
-
//----------------------------------------------------------------------
// WebGraphicsContext3D methods
virtual bool makeContextCurrent();
@@ -532,10 +530,15 @@ class WEBKIT_GPU_EXPORT WebGraphicsContext3DInProcessCommandBufferImpl
void OnSwapBuffersComplete();
virtual void OnContextLost();
+ bool MaybeInitializeGL();
+
// Used to try to find bugs in code that calls gl directly through the gl api
// instead of going through WebGraphicsContext3D.
void ClearContext();
+ bool initialized_;
+ bool initialize_failed_;
+
// The context we use for OpenGL rendering.
GLInProcessContext* context_;
// The GLES2Implementation we use for OpenGL rendering.

Powered by Google App Engine
This is Rietveld 408576698