Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290773009: [Android] Remove android_commands and android_testrunner. (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
CC:
bruening+watch_chromium.org, chromium-reviews, glider+watch_chromium.org, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, mikecase (-- gone --), rnephew (Reviews Here), yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove android_commands and android_testrunner. Good riddance. BUG=267773 Committed: https://crrev.com/d71baced2e55f9f102189c490908e3c631a790e2 Cr-Commit-Position: refs/heads/master@{#343210}

Patch Set 1 #

Patch Set 2 : -android_testrunner #

Total comments: 2

Patch Set 3 : msg3: sullivan comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3731 lines) Patch
M build/android/PRESUBMIT.py View 1 1 chunk +1 line, -3 lines 0 comments Download
M build/android/gyp/util/build_device.py View 1 chunk +5 lines, -2 lines 0 comments Download
M build/android/provision_devices.py View 1 2 chunks +1 line, -7 lines 0 comments Download
D build/android/pylib/android_commands.py View 1 chunk +0 lines, -1976 lines 0 comments Download
D build/android/pylib/android_commands_unittest.py View 1 chunk +0 lines, -191 lines 0 comments Download
M build/android/pylib/device/battery_utils_test.py View 1 1 chunk +0 lines, -5 lines 0 comments Download
M build/android/pylib/device/decorators.py View 1 2 chunks +0 lines, -12 lines 0 comments Download
M build/android/pylib/device/decorators_test.py View 1 5 chunks +0 lines, -77 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 2 chunks +0 lines, -7 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 3 chunks +0 lines, -12 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 3 chunks +13 lines, -4 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +0 lines, -2 lines 0 comments Download
D build/android/pylib/system_properties.py View 1 chunk +0 lines, -40 lines 0 comments Download
M build/android/pylib/valgrind_tools.py View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/android_testrunner/LICENSE View 1 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/android_testrunner/OWNERS View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/android_testrunner/README.chromium View 1 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/android_testrunner/adb_interface.py View 1 1 chunk +0 lines, -522 lines 0 comments Download
D third_party/android_testrunner/am_instrument_parser.py View 1 1 chunk +0 lines, -169 lines 0 comments Download
D third_party/android_testrunner/errors.py View 1 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/android_testrunner/logger.py View 1 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/android_testrunner/patch.diff View 1 1 chunk +0 lines, -104 lines 0 comments Download
D third_party/android_testrunner/run_command.py View 1 1 chunk +0 lines, -192 lines 0 comments Download
M tools/android/appstats.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/checkperms/checkperms.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/cygprofile/profile_android_startup.py View 1 2 7 chunks +20 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
jbudorick
5 years, 4 months ago (2015-08-13 13:05:26 UTC) #2
sullivan
lgtm https://codereview.chromium.org/1290773009/diff/20001/tools/cygprofile/profile_android_startup.py File tools/cygprofile/profile_android_startup.py (right): https://codereview.chromium.org/1290773009/diff/20001/tools/cygprofile/profile_android_startup.py#newcode227 tools/cygprofile/profile_android_startup.py:227: return 1 Are we swallowing debugging output when ...
5 years, 4 months ago (2015-08-13 13:12:23 UTC) #3
jbudorick
https://codereview.chromium.org/1290773009/diff/20001/tools/cygprofile/profile_android_startup.py File tools/cygprofile/profile_android_startup.py (right): https://codereview.chromium.org/1290773009/diff/20001/tools/cygprofile/profile_android_startup.py#newcode227 tools/cygprofile/profile_android_startup.py:227: return 1 On 2015/08/13 at 13:12:23, sullivan wrote: > ...
5 years, 4 months ago (2015-08-13 13:15:31 UTC) #4
sullivan
On 2015/08/13 13:15:31, jbudorick wrote: > https://codereview.chromium.org/1290773009/diff/20001/tools/cygprofile/profile_android_startup.py > File tools/cygprofile/profile_android_startup.py (right): > > https://codereview.chromium.org/1290773009/diff/20001/tools/cygprofile/profile_android_startup.py#newcode227 > ...
5 years, 4 months ago (2015-08-13 13:22:05 UTC) #5
jbudorick
+thakis for third_party/ OWNERS
5 years, 4 months ago (2015-08-13 13:47:44 UTC) #7
Nico
On 2015/08/13 13:47:44, jbudorick wrote: > +thakis for third_party/ OWNERS Lgtm
5 years, 4 months ago (2015-08-13 15:22:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290773009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290773009/40001
5 years, 4 months ago (2015-08-13 15:34:12 UTC) #10
craigdh
Nice to see this! LGTM!
5 years, 4 months ago (2015-08-13 16:13:40 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-13 16:31:31 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/d71baced2e55f9f102189c490908e3c631a790e2 Cr-Commit-Position: refs/heads/master@{#343210}
5 years, 4 months ago (2015-08-13 16:32:25 UTC) #13
csharp
5 years, 4 months ago (2015-08-13 16:49:41 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1288993002/ by csharp@chromium.org.

The reason for reverting is: This seems to have broken the Google Chrome Linux
x64 build

Output:
FAILED: cd ../../content; python ../tools/isolate_driver.py check --isolated
"../out/Release/telemetry_gpu_unittests.isolated" --isolate
"telemetry_gpu_unittests.isolate" --path-variable DEPTH .. --path-variable
PRODUCT_DIR "../out/Release " --extra-variable "version_full=46.0.2482.0"
--config-variable "CONFIGURATION_NAME=Release" --config-variable "OS=linux"
--config-variable "asan=0" --config-variable "branding=Chrome" --config-variable
"chromeos=0" --config-variable "component=static_library" --config-variable
"disable_nacl=0" --config-variable "enable_pepper_cdms=1" --config-variable
"enable_plugins=1" --config-variable "fastbuild=0" --config-variable
"icu_use_data_file_flag=1" --config-variable "internal_gles2_conform_tests=0"
--config-variable "kasko=0" --config-variable
"libpeer_target_type=static_library" --config-variable "lsan=0"
--config-variable "msan=0" --config-variable "target_arch=x64" --config-variable
"tsan=0" --config-variable "use_custom_libcxx=0" --config-variable
"use_instrumented_libraries=0" --config-variable
"use_prebuilt_instrumented_libraries=0" --config-variable "use_openssl=1"
--config-variable "use_ozone=0" --config-variable "use_x11=1" --config-variable
"v8_use_external_startup_data=1"
Failed to find an input file:
/b/build/slave/google-chrome-rel-linux_64/build/src/third_party/android_testrunner/
is not a directory but ends with "/".

Powered by Google App Engine
This is Rietveld 408576698