Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1290703002: Do not save script object on the class constructor. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not save script object on the class constructor. We don't need it, as we can grab it from the shared function info. Having it triggers an assertion if we define classes in native JS. R=bmeurer@chromium.org, rossberg@chromium.org Committed: https://crrev.com/abc12df33c0dd188441acbf1646048111bdaf1be Cr-Commit-Position: refs/heads/master@{#30134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -44 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-classes.cc View 5 chunks +16 lines, -36 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Yang
5 years, 4 months ago (2015-08-12 11:55:01 UTC) #1
Yang
5 years, 4 months ago (2015-08-12 11:56:15 UTC) #3
rossberg
lgtm
5 years, 4 months ago (2015-08-12 12:31:27 UTC) #4
Michael Lippautz
heap lgtm
5 years, 4 months ago (2015-08-12 12:39:53 UTC) #5
Benedikt Meurer
LGTM, nice catch!
5 years, 4 months ago (2015-08-12 12:40:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290703002/1
5 years, 4 months ago (2015-08-12 12:40:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 13:06:08 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 13:06:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abc12df33c0dd188441acbf1646048111bdaf1be
Cr-Commit-Position: refs/heads/master@{#30134}

Powered by Google App Engine
This is Rietveld 408576698