Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 12907011: cc: Allow command line flag to prevent unit test timeouts. (Closed)

Created:
7 years, 9 months ago by danakj
Modified:
7 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman, backer
Visibility:
Public.

Description

cc: Allow command line flag to prevent unit test timeouts. When running layer tree tests in gdb, they easily time out while stepping through code. This allows a command line flag to override the timeout behaviour so that you can run the tests in gdb without having to comment out the Timeout() method. The flag is --cc-layer-tree-test-no-timeout to make sure it's not given by accident on the bots. R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190605

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M cc/test/layer_tree_test.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
7 years, 9 months ago (2013-03-26 02:25:35 UTC) #1
enne (OOO)
lgtm, cq+
7 years, 9 months ago (2013-03-26 06:49:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12907011/2001
7 years, 9 months ago (2013-03-26 07:16:33 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 08:58:58 UTC) #4
Message was sent while issue was closed.
Change committed as 190605

Powered by Google App Engine
This is Rietveld 408576698