Issue 12907006: Isolatify HeapProfiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12907006: Isolatify HeapProfiler (Closed)

Created:
7 years, 9 months ago by yurys

Modified:
7 years, 9 months ago

Reviewers:
Sven Panne, alph, loislo

CC:
chromium-reviews

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Isolatify HeapProfiler Added instance method on v8::Isolate for retrieving instance of v8::HeapProfiler for that isolate. All static methods of v8::HeapProfiler are deprecated, corresponding instance methods are added to v8::HeapProfiler. All static methods on v8::internal::HeapProfiler were converted into instance ones. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=13997

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Expose v8::HeapProfiler instance on v8::Isolate #

Patch Set 4 : Removed V8_DEPRECATED for now, Chromium usages should be fixed first #

Patch Set 5 : Prohibited construction and destruction of v8::HeapProfiler #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+314 lines, -250 lines)			Patch
M	include/v8.h	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	include/v8-profiler.h	View	1 2 3 4	6 chunks	+55 lines, -18 lines	0 comments	Download
M	src/api.cc	View	1 2	9 chunks	+86 lines, -12 lines	0 comments	Download
M	src/heap-profiler.h	View		2 chunks	+13 lines, -31 lines	0 comments	Download
M	src/heap-profiler.cc	View		3 chunks	+13 lines, -90 lines	0 comments	Download
M	src/isolate.h	View		3 chunks	+2 lines, -1 line	0 comments	Download
M	src/isolate.cc	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 2	65 chunks	+134 lines, -96 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yurys

As suggested in https://codereview.chromium.org/12706020/#msg7 public heap profiler API is extended with methods that accept explicit ...

7 years, 9 months ago (2013-03-19 17:09:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r13997.

Expand Messages | Collapse Messages