Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 1290693003: Presentation API: add UMA. (Closed)

Created:
5 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -10 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/modules/presentation/Presentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/presentation/PresentationAvailability.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/presentation/PresentationAvailability.cpp View 1 2 chunks +9 lines, -0 lines 0 comments Download
M Source/modules/presentation/PresentationRequest.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/presentation/PresentationRequest.cpp View 1 2 chunks +9 lines, -0 lines 0 comments Download
M Source/modules/presentation/PresentationRequest.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/presentation/PresentationSession.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/presentation/PresentationSession.cpp View 2 chunks +13 lines, -1 line 0 comments Download
M Source/modules/presentation/PresentationSession.idl View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
mlamouri (slow - plz ping)
Could you PTAL and let me know if there are some UMA you think should ...
5 years, 4 months ago (2015-08-12 16:56:53 UTC) #2
mark a. foltz
lgtm https://codereview.chromium.org/1290693003/diff/1/Source/modules/presentation/Presentation.idl File Source/modules/presentation/Presentation.idl (right): https://codereview.chromium.org/1290693003/diff/1/Source/modules/presentation/Presentation.idl#newcode11 Source/modules/presentation/Presentation.idl:11: [MeasureAs=PresentationDefaultRequest] attribute PresentationRequest? defaultRequest; Does this measure the ...
5 years, 4 months ago (2015-08-12 17:32:53 UTC) #3
mlamouri (slow - plz ping)
On 2015/08/12 at 17:32:53, mfoltz wrote: > lgtm > > https://codereview.chromium.org/1290693003/diff/1/Source/modules/presentation/Presentation.idl > File Source/modules/presentation/Presentation.idl (right): ...
5 years, 4 months ago (2015-08-12 17:35:12 UTC) #4
whywhat
lgtm
5 years, 4 months ago (2015-08-12 18:01:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290693003/1
5 years, 4 months ago (2015-08-12 18:02:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/39607)
5 years, 4 months ago (2015-08-12 18:10:09 UTC) #9
mlamouri (slow - plz ping)
Mike, can you review the UseCounter.h change?
5 years, 4 months ago (2015-08-12 18:24:38 UTC) #11
mlamouri (slow - plz ping)
Review ping: mkwst@, could you PTAL?
5 years, 4 months ago (2015-08-15 14:02:58 UTC) #12
Mike West
UseCounter.h LGTM
5 years, 4 months ago (2015-08-15 14:19:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290693003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290693003/20001
5 years, 4 months ago (2015-08-15 15:03:25 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 16:32:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200610

Powered by Google App Engine
This is Rietveld 408576698