Issue 1290663005: Rename is_chromeos in widevine/cdm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1290663005: Rename is_chromeos in widevine/cdm. (Closed)

Created:
5 years, 4 months ago by Peter Mayo

Modified:
5 years, 4 months ago

Reviewers:
ddorwin

CC:
chromium-reviews, eme-reviews_chromium.org, ddorwin

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rename is_chromeos in widevine/cdm. is_chromeos does a poor job of distinguishing developer builds of chrome for chromeos for your desktop, and chrome for chromeos on a device (where the runtimes are non local, for example) Split this into is_chromeos_ui and is_chromeos_os. BUG=519943 TEST=ChromiumOS compiles equivalently.

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/widevine/cdm/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Peter Mayo

Dependent on https://codereview.chromium.org/1283313004/ upload suggested ddorwin@chromium.org as a reviewer.

5 years, 4 months ago (2015-08-13 01:20:04 UTC) #1

ddorwin

5 years, 4 months ago (2015-08-18 18:56:23 UTC) #3

This LGTM. However, I'm not sure "ui" is the correct label for such
functionality. I'll reply in the main CL.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages